chore(launcher): put pipeline context as parent of run context. Part of #5669 #5785
Conversation
|
/hold |
| _, err := c.svc.PutParentContexts(ctx, req) | ||
| if err != nil { | ||
| if status.Convert(err).Code() == codes.AlreadyExists { | ||
| // already exists code is expected when multiple requests are sent in parallel |
There was a problem hiding this comment.
Can we add a logging here which indicates that the parental edge already exists
There was a problem hiding this comment.
This will happen too many times, it's probably not worth logging.
(Because every task runs in parallel, only the first task will successfully put the parent edge, all other tasks will get this already exists status code)
|
Do we need to modify the e2e test to verify that the parental edges exists in MLMD? |
Not sure, I feel that the extra test is not of enough value when we already verify in the unit test (with a real MLMD server). |
|
/retest |
|
/unhold |
|
/lgtm |
|
Thanks |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Description of your changes:
put pipeline context as parent of run context
Part of #5669
Checklist: