Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sample): Add markdown visualization example for v1 and v2 compatible #5936

Merged
merged 4 commits into from
Jun 29, 2021

Conversation

zijianjoy
Copy link
Collaborator

@zijianjoy zijianjoy commented Jun 28, 2021

Description of your changes:
Partial #5932

Ability to run same pipeline for v1 and v2 compatible, it will generate Markdown for UI visualization.

Command to initialize test:

python3 -m samples.core.visualization.markdown_test

mdviewer

Checklist:

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for building an example for markdown!

samples/core/visualization/markdown.py Outdated Show resolved Hide resolved
samples/core/visualization/markdown.py Outdated Show resolved Hide resolved
samples/core/visualization/markdown.py Outdated Show resolved Hide resolved
@Bobgy
Copy link
Contributor

Bobgy commented Jun 28, 2021

/lgtm

@Bobgy
Copy link
Contributor

Bobgy commented Jun 29, 2021

/retest

@Bobgy Bobgy changed the title feat(sample) Add markdown visualization example for v1 and v2 compatible feat(sample): Add markdown visualization example for v1 and v2 compatible Jun 29, 2021
@Bobgy
Copy link
Contributor

Bobgy commented Jun 29, 2021

Note, the title has to be feat(scope): title. Do not omit the : and the space.

@Bobgy
Copy link
Contributor

Bobgy commented Jun 29, 2021

/lgtm
/approve
Thank you for adding the two samples!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 565d03e into kubeflow:master Jun 29, 2021
@zijianjoy
Copy link
Collaborator Author

Note, the title has to be feat(scope): title. Do not omit the : and the space.

Thank you Yuan @Bobgy for the reminder! I should remember to add the : and space to title.

On the related note, I wonder if it helps if we align the approach of title naming with issue creation? On Issue creation, we add labels areas/frontend, areas/samples. It will be shown on the PR title when we visit https://github.com/kubeflow/pipelines/pulls, and we can filter by label to find issues under certain area as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants