Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sample notebook to clean up deployed models. #622

Merged
merged 3 commits into from
Jan 4, 2019
Merged

Update sample notebook to clean up deployed models. #622

merged 3 commits into from
Jan 4, 2019

Conversation

qimingj
Copy link
Contributor

@qimingj qimingj commented Jan 4, 2019 •
edited by jlewi
Loading

Also update SDK client to return correct links in local Jupyter with user's own proxy connection.

This change is Reviewable

@qimingj
Update sample notebook to clean up deployed models.
d937a55 
Update SDK client to return correct links in local Jupyter with user's own proxy connection.
@gaoning777
Copy link
Contributor

/lgtm

gaoning777
gaoning777 approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify that the models are indeed cleaned? And the sample tests pass?

@qimingj
Copy link
Contributor Author

qimingj commented Jan 4, 2019

yes. Will do.

@qimingj
Copy link
Contributor Author

qimingj commented Jan 4, 2019

PTAL

@gaoning777
Copy link
Contributor

/lgtm

@qimingj
Copy link
Contributor Author

qimingj commented Jan 4, 2019

Verified that sample tests passed and after running the tests no new models were left over.

@qimingj
Copy link
Contributor Author

qimingj commented Jan 4, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 410f9b9 into kubeflow:master Jan 4, 2019
@gaoning777
Copy link
Contributor

Looks that the change you made was reverted by the master branch merge.
Fixing the issue: #636

@gaoning777 gaoning777 mentioned this pull request Jan 7, 2019
Closed
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
@gabrielwen @jlewi
Tekton prow scripts (kubeflow#622)
c62601d 
* Implement Tekton script and link to run_e2e_workflow

* remove pvc config - not used anymore

* README

update pr num

fix

doc

inject

fix

fix

update doc

* Comment out notebook tekton tests

* Add some TODOs.

Co-authored-by: Jeremy Lewi <jeremy+github@lewi.us>
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@ScrapCodes
fix(scripts): deploy-ibm-vpc.sh public gateway detection. (kubeflow#622)
87dd3a7 
A VPC may have more than one public gateways and they may be in
different cluster zones. So now filtering on cluster_zone and
picking the first public gateway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 gaoning777 approved these changes

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

Assignees

@gaoning777 gaoning777

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qimingj @gaoning777 @k8s-ci-robot