Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): Remove stack trace so it doesn't look like an error #6590

Merged
merged 4 commits into from
Sep 24, 2021

Conversation

randombishop
Copy link
Contributor

Description of your changes:

Checklist:

@google-cla
Copy link

google-cla bot commented Sep 21, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-oss-robot
Copy link

Hi @randombishop. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@randombishop randombishop changed the title Stack trace makes it look like an error fix: Remove stack trace so it doesn't look like an error Sep 21, 2021
@randombishop
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 21, 2021
@capri-xiyue
Copy link
Contributor

/lgtm
@chensun Can you help take a look at this pr?

@chensun
Copy link
Member

chensun commented Sep 24, 2021

@randombishop Thanks for the PR. Can you please add an entry in the release note under "Current version > bug fixes and other changes"?
https://github.com/kubeflow/pipelines/blob/master/sdk/RELEASE.md

@randombishop
Copy link
Contributor Author

@chensun Done, thanks for the review.

@chensun
Copy link
Member

chensun commented Sep 24, 2021

/lgtm
/approve

Thanks!

@chensun
Copy link
Member

chensun commented Sep 24, 2021

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun chensun changed the title fix: Remove stack trace so it doesn't look like an error chore(sdk): Remove stack trace so it doesn't look like an error Sep 24, 2021
@chensun
Copy link
Member

chensun commented Sep 24, 2021

Fixes: #6589

@google-oss-robot google-oss-robot merged commit 95162e2 into kubeflow:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants