Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): relax typing-extensions version to >=3.7.4,<4. Fixes #6651 #6683

Merged

Conversation

chensun
Copy link
Member

@chensun chensun commented Oct 5, 2021

Description of your changes:
Fixes #6651

Checklist:

@chensun chensun requested a review from ji-yaqi October 5, 2021 07:39
@google-cla google-cla bot added the cla: yes label Oct 5, 2021
@chensun chensun changed the title chore(sdk): relax typing-extension version to >=3.7.4,<4. Fixes #6651 chore(sdk): relax typing-extensions version to >=3.7.4,<4. Fixes #6651 Oct 5, 2021
@chensun
Copy link
Member Author

chensun commented Oct 5, 2021

/test kubeflow-pipelines-samples-v2

1 similar comment
@ji-yaqi
Copy link
Contributor

ji-yaqi commented Oct 5, 2021

/test kubeflow-pipelines-samples-v2

@ji-yaqi
Copy link
Contributor

ji-yaqi commented Oct 5, 2021

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ji-yaqi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@chensun
Copy link
Member Author

chensun commented Oct 6, 2021

/test kubeflow-pipelines-samples-v2

@chensun chensun added the lgtm label Oct 6, 2021
@google-oss-robot google-oss-robot merged commit 7b4f283 into kubeflow:master Oct 6, 2021
@chensun chensun deleted the relax-typing-extension-version branch October 6, 2021 05:50
@juliusvonkohout
Copy link
Member

@chensun does this also fix click<9,>=7.1.1 ?

copybara-service bot pushed a commit to tensorflow/tfx that referenced this pull request Jan 25, 2022
Incompatibility issue with TF 2.6 was resolved at kfp 1.8.5[1].

[1] kubeflow/pipelines#6683

PiperOrigin-RevId: 423940549
copybara-service bot pushed a commit to tensorflow/tfx that referenced this pull request Jan 25, 2022
Incompatibility issue with TF 2.6 was resolved at kfp 1.8.5[1].

[1] kubeflow/pipelines#6683

PiperOrigin-RevId: 423940549
copybara-service bot pushed a commit to tensorflow/tfx that referenced this pull request Jan 25, 2022
Incompatibility issue with TF 2.6 was resolved at kfp 1.8.5[1].

[1] kubeflow/pipelines#6683

PiperOrigin-RevId: 423940549
copybara-service bot pushed a commit to tensorflow/tfx that referenced this pull request Jan 25, 2022
Incompatibility issue with TF 2.6 was resolved at kfp 1.8.5[1].

[1] kubeflow/pipelines#6683

PiperOrigin-RevId: 423949826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdk] dependency conflict with tensorflow 2.6.0 and seldon-core
4 participants