Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): Extend SDK client with disable/delete run methods #6754

Merged
merged 7 commits into from
Oct 19, 2021
Merged

feat(sdk): Extend SDK client with disable/delete run methods #6754

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6334eff
add disbale/delete run (job) functions to sdk client
johnmacnamararseg Oct 18, 2021
6382897
change run to job to accuratly reflect api
johnmacnamararseg Oct 19, 2021
9c1fc47
add release note for change
johnmacnamararseg Oct 19, 2021
63191b3
align docstrings with style guide requirements
johnmacnamararseg Oct 19, 2021
135abad
resolve merge conflict in RELEASE file
johnmacnamararseg Oct 19, 2021
ec1b739
formatting
johnmacnamararseg Oct 19, 2021
5e1930a
Merge branch 'master' into sdk-client-delete-disable-job
chensun Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions sdk/python/kfp/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,6 +1056,34 @@ def __repr__(self):
)
return RunPipelineResult(self, run_info)

def delete_job(self, job_id):
"""Delete job.
johnmacnamararseg marked this conversation as resolved.
Show resolved Hide resolved

Args:
job_id: id of the job.

Returns:
Object. If the method is called asynchronously, returns the request thread.

Throws:
johnmacnamararseg marked this conversation as resolved.
Show resolved Hide resolved
Exception if job is not found.
johnmacnamararseg marked this conversation as resolved.
Show resolved Hide resolved
"""
return self._job_api.delete_job(id=job_id)

def disable_job(self, job_id):
"""Disable job.

Args:
job_id: id of the job.

Returns:
Object. If the method is called asynchronously, returns the request thread.

Throws:
Exception if job is not found.
"""
return self._job_api.disable_job(id=job_id)

def list_runs(self,
page_token='',
page_size=10,
Expand Down