Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): add deprecation warnings for v2 #6851

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

ji-yaqi
Copy link
Contributor

@ji-yaqi ji-yaqi commented Nov 2, 2021

Warning for upcoming changes in 2.0.0.

  1. v2 compiler: APIs imported from the v1 namespace (e.g. kfp.dsl, kfp.components, etc) will not be supported by the v2 compiler since v2.0.0. Please consider switching to v1 namespace with v1 compiler, or switching to v2 completely.

  2. Custom job from experimental folder will be removed. Please consider using Vertex AI SDK for custom jobs and other functionalities.

  3. AIPlatformClient will be deprecated in 2.0.0. Please consider using PipelineJob in Vertex AI SDK for submitting pipelines.

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Nov 2, 2021
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun chensun changed the title chore: add deprecation warnings for v2 chore(sdk): add deprecation warnings for v2 Nov 2, 2021
@google-oss-robot google-oss-robot merged commit 334307d into kubeflow:master Nov 2, 2021
chensun pushed a commit to chensun/pipelines that referenced this pull request Nov 2, 2021
@chensun chensun added the cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch label Nov 2, 2021
google-oss-robot pushed a commit that referenced this pull request Nov 3, 2021
)

* fix(sdk): fix cloud scheduler's job name (#6844)

* chore(sdk): add deprecation warnings for v2 (#6851)

* chore(sdk): Release 1.8.8 off `sdk/release-1.8` branch (#6853)

Co-authored-by: Trs <trsnium@gmail.com>
Co-authored-by: Yaqi Ji <jiyaqi0712@gmail.com>
@chensun chensun added the cherrypicked cherry picked to release branch `release-x.y` label Nov 4, 2021
abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
…e-1.8 branch (kubeflow#6852)

* fix(sdk): fix cloud scheduler's job name (kubeflow#6844)

* chore(sdk): add deprecation warnings for v2 (kubeflow#6851)

* chore(sdk): Release 1.8.8 off `sdk/release-1.8` branch (kubeflow#6853)

Co-authored-by: Trs <trsnium@gmail.com>
Co-authored-by: Yaqi Ji <jiyaqi0712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` cla: yes lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants