Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk): Make Artifact type be compatible with any sub-artifact types bidirectionally #6859

Merged
merged 1 commit into from
Nov 3, 2021
Merged

fix(sdk): Make Artifact type be compatible with any sub-artifact types bidirectionally #6859

merged 1 commit into from
Nov 3, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Nov 3, 2021

Description of your changes:

Checklist:

@google-cla google-cla bot added the cla: yes label Nov 3, 2021
@google-oss-prow google-oss-prow bot requested a review from Bobgy November 3, 2021 18:40
@chensun
Copy link
Member Author

chensun commented Nov 3, 2021

/test kubeflow-pipelines-tfx-python37

@ji-yaqi
Copy link
Contributor

ji-yaqi commented Nov 3, 2021

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Nov 3, 2021
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ji-yaqi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun
Copy link
Member Author

chensun commented Nov 3, 2021

Will ignore kubeflow-pipelines-tfx-python37: #6860

@chensun chensun added the cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch label Nov 3, 2021
@chensun
Copy link
Member Author

chensun commented Nov 3, 2021

/retest

@google-oss-robot google-oss-robot merged commit dea0823 into kubeflow:master Nov 3, 2021
chensun added a commit to chensun/pipelines that referenced this pull request Nov 4, 2021
@chensun
fix(sdk): Make Artifact type be compatible with any sub-artifact ty…
809f177 
…pes bidirectionally (kubeflow#6859)
chensun added a commit that referenced this pull request Nov 4, 2021
@chensun
chore: Cherry pick #6859 and #6864 to sdk/release-1.8 branch (#6865)
16f2a2f 
* fix(sdk): Make `Artifact` type be compatible with any sub-artifact types bidirectionally (#6859)

* chore(sdk): Release KFP SDK 1.8.9 off `sdk/release-1.8` branch (#6864)

* Update RELEASE.md

* Update __init__.py
@chensun chensun deleted the artifact-type-compat branch June 9, 2022 07:00
@chensun chensun added the cherrypicked cherry picked to release branch `release-x.y` label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@ji-yaqi ji-yaqi Awaiting requested review from ji-yaqi

@Bobgy Bobgy Awaiting requested review from Bobgy

Assignees

@ji-yaqi ji-yaqi

Labels
approved cherrypick-approved area OWNER approves to cherry pick this PR to current active release branch cherrypicked cherry picked to release branch `release-x.y` cla: yes lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chensun @ji-yaqi @google-oss-robot