Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk): Respect namespace if set on client #7056

Merged
merged 9 commits into from
Jan 11, 2022
Merged

fix(sdk): Respect namespace if set on client #7056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cee0a23
respect namespace if set on client
casassg Dec 13, 2021
b76c382
make sure is_multi_user
casassg Dec 13, 2021
f31d410
overwrite directly context_setting
casassg Dec 16, 2021
1913ab8
revert non-related changes
casassg Dec 16, 2021
0cc53b7
revert overwrite_namespace
casassg Dec 16, 2021
a2193ff
expand text
casassg Dec 16, 2021
5475f2e
add release notes
casassg Jan 10, 2022
0f5e0e5
Merge branch 'master' into gcasassaez/fix-namespace-client
casassg Jan 10, 2022
aaffe1a
add PR link
casassg Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* Add ImporterSpec v2 [\#6917](https://github.com/kubeflow/pipelines/pull/6917)
* Add add set_env_variable for Pipeline task [\#6919](https://github.com/kubeflow/pipelines/pull/6919)
* Add metadata field for importer [\#7112](https://github.com/kubeflow/pipelines/pull/7112)
* kfp.Client uses namespace from initialization if set for the instance context [\#7056](https://github.com/kubeflow/pipelines/pull/7056).

## Breaking Changes

Expand Down
6 changes: 6 additions & 0 deletions sdk/python/kfp/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,12 @@ def __init__(self,
# Save the loaded API client configuration, as a reference if update is
# needed.
self._load_context_setting_or_default()

# If custom namespace provided, overwrite the loaded or default one in
# context settings for current client instance
if namespace != 'kubeflow':
self._context_setting['namespace'] = namespace

self._existing_config = config
if cookies is None:
cookies = self._context_setting.get('client_authentication_cookie')
Expand Down