Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk): bumps up absl version to 1.x for compatibility with TF 2.8+. Fixes #7171 #7172

Merged
merged 3 commits into from
Jan 19, 2022
Merged

fix(sdk): bumps up absl version to 1.x for compatibility with TF 2.8+. Fixes #7171 #7172

merged 3 commits into from
Jan 19, 2022

Conversation

jiyongjung0
Copy link
Contributor

@jiyongjung0 jiyongjung0 commented Jan 19, 2022 •
edited
Loading

Description of your changes:
Updates the maximum absl version to 1.x for more compatibility. There is no breaking change in absl between 0.12 and 1.0 CHANGELOG.

Please see #7171 for the related issue.

Checklist:

@google-oss-prow
Copy link

Hi @jiyongjung0. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot requested review from chensun and ji-yaqi January 19, 2022 00:48
@chensun
Copy link
Member

chensun commented Jan 19, 2022

/ok-to-test

@chensun
Copy link
Member

chensun commented Jan 19, 2022

Thanks @jiyongjung0. Can you please add an entry in the release note similar to this one?

@jiyongjung0
Copy link
Contributor Author

@chensun Added a release note. Thanks!

@chensun
Copy link
Member

chensun commented Jan 19, 2022

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Jan 19, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 22a8fdf into kubeflow:master Jan 19, 2022
chensun pushed a commit to chensun/pipelines that referenced this pull request Jan 21, 2022
@chensun
fix(sdk): bumps up absl version to 1.x for compatibility with TF 2.8+. …
bc73438 
…Fixes kubeflow#7171 (kubeflow#7172)

* Bumps up absl version to 1.x for compatibility with TF 2.8+.

* Adds a release note for absl version.
chensun added a commit that referenced this pull request Jan 24, 2022
@chensun @casassg @SebBlin
chore(sdk1.8): cherry pick #6866, #7056, #7141, #7143, #7168, #7172, #…
7b2ca38 
…7182 into sdk/release-1.8 branch. (#7200)

* test: fix tfx presubmit test. (#7143)

* fix(sdk): Respect namespace if set on client (#7056)

* respect namespace if set on client

* make sure is_multi_user

* overwrite directly context_setting

* revert non-related changes

* revert overwrite_namespace

* expand text

* add release notes

* add PR link

* fix(sdk): Support per workflow TTL (ttl_seconds_after_finished) with new format of Argo workflow manifest (#7141)

* Support per workflow TTL (ttl_seconds_after_finished) with new format of Argo workflow manifest

* Update test for TTL

* Declare fix in release note of SDK

* update syntaxe

* Update RELEASE.md

Add Braking change due to incompatibility with  KFP pre 1.7 due to Argo 2.X

* chore(sdk): Remove redundant check in set_gpu_limit (#6866)

* remove redundant check in set_gpu_limit

* release note

* fix(sdk): Fix create_runtime_artifact not covering all types. (#7168)

* Fix create_runtime_artifact not covering all types.

* release note

* fix(sdk): bumps up absl version to 1.x for compatibility with TF 2.8+. Fixes #7171 (#7172)

* Bumps up absl version to 1.x for compatibility with TF 2.8+.

* Adds a release note for absl version.

* chore(sdk): Update SDK release note for the upcoming 1.8.11 release (#7182)

Co-authored-by: Gerard Casas Saez <gcasassaez@twitter.com>
Co-authored-by: Seb <sebastien.blin@gmail.com>
Co-authored-by: Jiyong Jung <jiyongjung@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensun chensun Awaiting requested review from chensun

@ji-yaqi ji-yaqi Awaiting requested review from ji-yaqi

Assignees

@chensun chensun

Labels
approved lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiyongjung0 @chensun