Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): fix yaml support create_run_from_pipeline_func #7500

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

chensun
Copy link
Member

@chensun chensun commented Mar 31, 2022

Description of your changes:
Missed this in my previous PR: #7458.
Discovered this while trying create_run_from_pipeline_func and manually verified the fix work.

Checklist:

Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: connor-mccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun
Copy link
Member Author

chensun commented Apr 1, 2022

/test kubeflow-pipelines-samples-v2

@chensun
Copy link
Member Author

chensun commented Apr 1, 2022

/retest

@google-oss-prow google-oss-prow bot merged commit 9e708b9 into kubeflow:master Apr 1, 2022
@chensun chensun deleted the fix-ir-yaml-in-client branch April 4, 2022 20:43
abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants