chore(sdk): clean up v2 CLI #7558
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test all |
connor-mccarthy
force-pushed
the
clean-up-v2-cli
branch
from
d1f53a3
to
5aaf6a4
Compare
|
/retest |
1 similar comment
|
/retest |
|
I left some nitpick comments in #7559, looks like I should have add them here instead. Anyway, I think you would be able to apply any changes here. :) |
|
/lgtm Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-pipelines-samples-v2 |
|
/retest |
1 similar comment
|
/retest |
|
@connor-mccarthy: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* remove linting comments * move global variable to local * simplify diagnose_me command * use f-strings * idiomatic python refactorings * remove unused import * add typestub library * silence unresolvable mypy error * update type information * remove unused variable * remove unused import * use __main__.py for cli entrypoint * expand imports
Description of your changes:
Cleans up V2 CLI source code before introducing substantive
changes.
Checklist:
title convention. Learn more about the pull request title convention used in this repository.