-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): add archive, unarchive, and delete run methods and tidy docstrings #7562
Conversation
Hi @droctothorpe. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, Alex. Just a few notes.
e10f2a3
to
0aede21
Compare
d511d7f
to
961c853
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Alex. Just a few more change suggestions and a question for @ji-yaqi.
3afc594
to
1a98bd9
Compare
86aa172
to
9c58f96
Compare
9c58f96
to
ef5ddf4
Compare
/test all |
/approve Thanks @droctothorpe! Glad to get this merged :). |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: connor-mccarthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks, @connor-mccarthy. Really appreciate all of the insightful feedback! |
Description of your changes:
The PR adds
archive_run
,unarchive_run
, anddelete_run
methods to theClient
class. It just consumes the associated methods in the Python client. No additional logic. Please let me know if you'd like me to add it the v1 client as well.It also tidies up some of the type hints and docstrings.
Once this is merged, I can contribute a discrete PR to update this test and potentially others that don't clean up artifacts.
Checklist: