Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): add archive, unarchive, and delete run methods and tidy docstrings #7562

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

droctothorpe
Copy link
Contributor

@droctothorpe droctothorpe commented Apr 14, 2022

Description of your changes:
The PR adds archive_run, unarchive_run, and delete_run methods to the Client class. It just consumes the associated methods in the Python client. No additional logic. Please let me know if you'd like me to add it the v1 client as well.

It also tidies up some of the type hints and docstrings.

Once this is merged, I can contribute a discrete PR to update this test and potentially others that don't clean up artifacts.

Checklist:

@google-oss-prow
Copy link

Hi @droctothorpe. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@connor-mccarthy
Copy link
Member

/test all

Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, Alex. Just a few notes.

sdk/python/kfp/client/client.py Outdated Show resolved Hide resolved
sdk/python/kfp/client/client.py Outdated Show resolved Hide resolved
sdk/python/kfp/client/client.py Outdated Show resolved Hide resolved
@droctothorpe droctothorpe force-pushed the clean-runs branch 5 times, most recently from e10f2a3 to 0aede21 Compare April 14, 2022 18:02
@droctothorpe droctothorpe changed the title feat(sdk): add archive, unarchive, and delete run methods feat(sdk): add archive, unarchive, and delete run methods and tidy docstrings Apr 14, 2022
@droctothorpe droctothorpe force-pushed the clean-runs branch 3 times, most recently from d511d7f to 961c853 Compare April 14, 2022 22:08
Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Alex. Just a few more change suggestions and a question for @ji-yaqi.

sdk/python/kfp/client/client.py Outdated Show resolved Hide resolved
sdk/python/kfp/client/client.py Outdated Show resolved Hide resolved
sdk/python/kfp/client/client.py Outdated Show resolved Hide resolved
@droctothorpe droctothorpe force-pushed the clean-runs branch 2 times, most recently from 3afc594 to 1a98bd9 Compare April 15, 2022 17:58
@droctothorpe droctothorpe force-pushed the clean-runs branch 3 times, most recently from 86aa172 to 9c58f96 Compare April 24, 2022 16:18
@connor-mccarthy
Copy link
Member

/test all

@connor-mccarthy
Copy link
Member

/approve
/lgtm

Thanks @droctothorpe! Glad to get this merged :).

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: connor-mccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2636727 into kubeflow:master Apr 25, 2022
@droctothorpe
Copy link
Contributor Author

Thanks, @connor-mccarthy. Really appreciate all of the insightful feedback!

@droctothorpe droctothorpe deleted the clean-runs branch April 25, 2022 20:58
jagadeeshi2i pushed a commit to jagadeeshi2i/pipelines that referenced this pull request May 11, 2022
abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants