Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): add autocomplete and version options to kfp cli #7567

Merged
merged 2 commits into from
Apr 25, 2022
Merged

feat(sdk): add autocomplete and version options to kfp cli #7567

merged 2 commits into from
Apr 25, 2022

Conversation

connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented Apr 14, 2022 •
edited
Loading

Description of your changes:
Adds kfp --version, kfp --show-completion, and kfp --install-completion to CLI.

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy connor-mccarthy marked this pull request as ready for review April 14, 2022 22:10
@connor-mccarthy
Copy link
Member Author

/hold Merge after #7559.

@google-oss-prow google-oss-prow bot added size/M and removed size/XL labels Apr 21, 2022
@connor-mccarthy
Copy link
Member Author

/unhold

@connor-mccarthy connor-mccarthy marked this pull request as draft April 21, 2022 02:35
@connor-mccarthy
Copy link
Member Author

/hold Merge after #7569.

@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Apr 21, 2022
@connor-mccarthy connor-mccarthy marked this pull request as ready for review April 21, 2022 13:51
@connor-mccarthy connor-mccarthy force-pushed the add-helpful-options-to-cli branch 3 times, most recently from ee86e61 to b659e1d Compare April 21, 2022 18:50
chensun
chensun reviewed Apr 22, 2022
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Apr 22, 2022
@ji-yaqi
Copy link
Contributor

ji-yaqi commented Apr 25, 2022

/lgtm
/approve

@google-oss-prow google-oss-prow bot removed the lgtm label Apr 25, 2022
@connor-mccarthy
Copy link
Member Author

/unhold

@ji-yaqi
Copy link
Contributor

ji-yaqi commented Apr 25, 2022

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Apr 25, 2022
@connor-mccarthy
Copy link
Member Author

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: connor-mccarthy, ji-yaqi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

@connor-mccarthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 c350eed link unknown /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@connor-mccarthy connor-mccarthy merged commit fbfeadd into kubeflow:master Apr 25, 2022
@connor-mccarthy connor-mccarthy mentioned this pull request May 3, 2022
Merged
1 task
jagadeeshi2i pushed a commit to jagadeeshi2i/pipelines that referenced this pull request May 11, 2022
@connor-mccarthy
feat(sdk): add autocomplete and version options to kfp cli (kubeflow#…
5bf7c86 
…7567)

* add helpful options to cli

* add tests
abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
@connor-mccarthy @abaland
feat(sdk): add autocomplete and version options to kfp cli (kubeflow#…
bd1f584 
…7567)

* add helpful options to cli

* add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensun chensun chensun left review comments

@ji-yaqi ji-yaqi Awaiting requested review from ji-yaqi

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@chensun chensun

@ji-yaqi ji-yaqi

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connor-mccarthy @ji-yaqi @chensun