Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): rename kfp artifact attributes (support custom artifact types pt. 1) #8191

Merged
merged 1 commit into from
Aug 27, 2022
Merged

feat(sdk): rename kfp artifact attributes (support custom artifact types pt. 1) #8191

merged 1 commit into from
Aug 27, 2022

Conversation

connor-mccarthy
Copy link
Member

Description of your changes:
Renames artifact class attributes from .TYPE_NAME to
.schema_title and .VERSION to .schema_version.

Also renames variables and parameters throughout to be consistent.

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy connor-mccarthy force-pushed the rename-kfp-artifact-attributes branch 2 times, most recently from f3e042c to 353ec43 Compare August 24, 2022 22:36
@google-oss-prow google-oss-prow bot added size/M and removed size/L labels Aug 24, 2022
@connor-mccarthy
Copy link
Member Author

/test all

@connor-mccarthy connor-mccarthy marked this pull request as ready for review August 24, 2022 22:56
@connor-mccarthy
Copy link
Member Author

/retest

1 similar comment
@connor-mccarthy
Copy link
Member Author

/retest

@connor-mccarthy connor-mccarthy mentioned this pull request Aug 25, 2022
Closed
1 task
chensun
chensun reviewed Aug 25, 2022
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Aug 25, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy
Copy link
Member Author

/retest

1 similar comment
@connor-mccarthy
Copy link
Member Author

/retest

@google-oss-prow google-oss-prow bot merged commit 72c1d10 into kubeflow:master Aug 27, 2022
@copybara-service copybara-service bot mentioned this pull request Sep 22, 2022
Merged
copybara-service bot pushed a commit that referenced this pull request Sep 22, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
4aa838b 
PiperOrigin-RevId: 476011683
copybara-service bot pushed a commit that referenced this pull request Sep 22, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
a4d29e5 
PiperOrigin-RevId: 476011683
copybara-service bot pushed a commit that referenced this pull request Sep 23, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
5508e1c 
PiperOrigin-RevId: 476011683
copybara-service bot pushed a commit that referenced this pull request Sep 24, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
60f136e 
PiperOrigin-RevId: 476011683
copybara-service bot pushed a commit that referenced this pull request Sep 27, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
052bc11 
PiperOrigin-RevId: 476011683
copybara-service bot pushed a commit that referenced this pull request Sep 27, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
fe60923 
PiperOrigin-RevId: 476011683
copybara-service bot pushed a commit that referenced this pull request Sep 27, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
61965ee 
PiperOrigin-RevId: 476011683
copybara-service bot pushed a commit that referenced this pull request Sep 29, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
d3a34d5 
PiperOrigin-RevId: 476011683
copybara-service bot pushed a commit that referenced this pull request Oct 14, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
147f446 
PiperOrigin-RevId: 476011683
copybara-service bot pushed a commit that referenced this pull request Oct 14, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
4616502 
PiperOrigin-RevId: 476011683
copybara-service bot pushed a commit that referenced this pull request Oct 15, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
a65877e 
PiperOrigin-RevId: 476011683
copybara-service bot pushed a commit that referenced this pull request Oct 15, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
4f941de 
PiperOrigin-RevId: 476011683
copybara-service bot pushed a commit that referenced this pull request Oct 15, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
c7dbbe5 
PiperOrigin-RevId: 476011683
copybara-service bot pushed a commit that referenced this pull request Oct 15, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
0e68d14 
PiperOrigin-RevId: 476011683
copybara-service bot pushed a commit that referenced this pull request Oct 15, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
7e85b79 
PiperOrigin-RevId: 476011683
copybara-service bot pushed a commit that referenced this pull request Oct 24, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
7638ee1 
PiperOrigin-RevId: 476011683
copybara-service bot pushed a commit that referenced this pull request Oct 24, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
3fcdd74 
PiperOrigin-RevId: 476011683
copybara-service bot pushed a commit that referenced this pull request Oct 24, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
6db034a 
PiperOrigin-RevId: 476011683
copybara-service bot pushed a commit that referenced this pull request Oct 24, 2022
@chongyouquan
chore(components): Temporary fix for artifact types (cf. #8191)
802cc98 
PiperOrigin-RevId: 483477877
jlyaoyuli pushed a commit to jlyaoyuli/pipelines that referenced this pull request Jan 5, 2023
@connor-mccarthy @jlyaoyuli
feat(sdk): rename kfp artifact attributes (support custom artifact ty…
90e29b4 
…pes pt. 1) (kubeflow#8191)
jlyaoyuli pushed a commit to jlyaoyuli/pipelines that referenced this pull request Jan 5, 2023
@chongyouquan @jlyaoyuli
chore(components): Temporary fix for artifact types (cf. kubeflow#8191)
49de8d1 
PiperOrigin-RevId: 483477877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensun chensun chensun left review comments

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@chensun chensun

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connor-mccarthy @chensun