-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): fix kfp component build
only produces empty requirements.txt
#8372
fix(sdk): fix kfp component build
only produces empty requirements.txt
#8372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This looks great. Thanks, @chensun.
A few thoughts that do not need to block merge:
- Perhaps add a release note, particularly to note the preservation of the user environment
requirements.txt
file - Unrelated to this PR: I think it might be good to update the CLI help text (docstrings) to use language that is consistent with our v2 documentation ("Containerized Python Components") here and here. The lack of identical language makes the current text slightly suggestive of CUJ3, particularly on line component.py:334. We can also probably drop the "v2" in the help text. IMO, this is implied by the
kfp
version the user is using, but I can see other views on this.
All good points! I prepared a release PR that will add the release note for this and some previous PRs. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…txt (kubeflow#8372) * fix CUJ2 always writes empty requirements.txt * sort dependencies
Description of your changes:
packages_to_install
, and install them at container build time.runtime-requirements.txt
so that users may keep theirrequirements.txt
which may contain dependencies for the entire project.runtime-requirements.txt
every time users runkfp component build
.Checklist: