Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): enable use of primitive placeholders in f-string #8494

Merged
merged 2 commits into from
Nov 28, 2022
Merged

feat(sdk): enable use of primitive placeholders in f-string #8494

merged 2 commits into from
Nov 28, 2022

Conversation

connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented Nov 23, 2022 •
edited
Loading

Description of your changes:
Enables use of primitive placeholders in f-string. ConcatPlaceholder and IfPresentPlaceholder still cannot be used in an f-string.

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy
Copy link
Member Author

/test all

@connor-mccarthy connor-mccarthy marked this pull request as ready for review November 23, 2022 22:41
@connor-mccarthy
Copy link
Member Author

/retest

@google-oss-prow
Copy link

google-oss-prow bot commented Nov 23, 2022 •
edited
Loading

@connor-mccarthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-tfx-python37 f2d84ae link true /test kubeflow-pipelines-tfx-python37

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@connor-mccarthy
Copy link
Member Author

/retest

chensun
chensun approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Nov 28, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun
Copy link
Member

chensun commented Nov 28, 2022 •
edited
Loading

/test-required

@chensun
Copy link
Member

chensun commented Nov 28, 2022

/retest

@chensun chensun merged commit b829e4a into kubeflow:master Nov 28, 2022
jlyaoyuli pushed a commit to jlyaoyuli/pipelines that referenced this pull request Jan 5, 2023
@connor-mccarthy @jlyaoyuli
feat(sdk): enable use of primitive placeholders in f-string (kubeflow…
a164e65 
…#8494)

* support primitive placeholders in fstring

* add read/write test component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensun chensun chensun approved these changes

@IronPan IronPan Awaiting requested review from IronPan

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@chensun chensun

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connor-mccarthy @chensun