Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): fix deserializing v1 component yaml defaults #8639

Conversation

connor-mccarthy
Copy link
Member

@connor-mccarthy connor-mccarthy commented Dec 29, 2022

Description of your changes:
Fixes two errors related to handling of v1 component YAML defaults:

  • Boolean types with defaults as strings (e.g., "True"/"true"/"False"/"false") could be loaded in, but could not be compiled.
  • Struct/Array types were loaded in, but not compiled correctly (compiled as a google.protobuf.Value.string_value instead of google.protobuf.Value.struct_value and google.protobuf.Value.list_value, respectively.

This PR fixes both and relocates all v1 component YAML default handling logic to the v1 component YAML deserialization code from v2 IR YAML compilation code.

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@connor-mccarthy
Copy link
Member Author

/assign @chensun

@connor-mccarthy connor-mccarthy force-pushed the fix-v1-bool-default-deserialization branch from 37ba45f to 7cb5921 Compare December 29, 2022 19:44
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Dec 29, 2022
@connor-mccarthy connor-mccarthy force-pushed the fix-v1-bool-default-deserialization branch from a7555c4 to 2d32401 Compare December 29, 2022 22:07
@connor-mccarthy connor-mccarthy changed the title fix(sdk): fix loading v1 component yaml with boolean default fix(sdk): fix deserializing v1 component yaml defaults Dec 29, 2022
@connor-mccarthy connor-mccarthy force-pushed the fix-v1-bool-default-deserialization branch 2 times, most recently from 9944ca6 to 35aabc5 Compare December 29, 2022 22:12
@connor-mccarthy connor-mccarthy force-pushed the fix-v1-bool-default-deserialization branch from 35aabc5 to 0fa28ed Compare December 29, 2022 22:13
@google-oss-prow
Copy link

@connor-mccarthy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-execution-tests 0fa28ed link true /test kubeflow-pipelines-sdk-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Dec 29, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy
Copy link
Member Author

kubeflow-pipelines-sdk-execution-tests failures are unrelated to this PR. Manually merging.

@connor-mccarthy connor-mccarthy merged commit 84241d6 into kubeflow:master Dec 29, 2022
jlyaoyuli pushed a commit to jlyaoyuli/pipelines that referenced this pull request Jan 5, 2023
* fix deserializing v1 defaults

* update test cases

* update type annotation

* add unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants