-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): fix deserializing v1 component yaml defaults #8639
fix(sdk): fix deserializing v1 component yaml defaults #8639
Conversation
Skipping CI for Draft Pull Request. |
0dc8caa
to
37ba45f
Compare
/assign @chensun |
37ba45f
to
7cb5921
Compare
a7555c4
to
2d32401
Compare
9944ca6
to
35aabc5
Compare
35aabc5
to
0fa28ed
Compare
@connor-mccarthy: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
* fix deserializing v1 defaults * update test cases * update type annotation * add unit tests
Description of your changes:
Fixes two errors related to handling of v1 component YAML defaults:
"True"
/"true"
/"False"
/"false"
) could be loaded in, but could not be compiled.google.protobuf.Value.string_value
instead ofgoogle.protobuf.Value.struct_value
andgoogle.protobuf.Value.list_value
, respectively.This PR fixes both and relocates all v1 component YAML default handling logic to the v1 component YAML deserialization code from v2 IR YAML compilation code.
Checklist:
title convention used in this repository.