-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): fixes module not found error for containerized python components. Fixes #8385 #9157
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @Mithil467. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Mithil467. This is great.
Could you sign the CLA?
Could you also add at least one representative test case for this specific bug to this test file? https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/cli/component_test.py
Fixes #8385 |
bea3c0d
to
0134ad9
Compare
c833aa2
to
f6fa4ea
Compare
@connor-mccarthy I have signed the CLA. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Mithil467. This looks and works great.
You can ignore the kubeflow-pipelines-sdk-execution-tests
failures. They are unrelated to your changes.
One request before we merge: could you add a release note about this fix to the "Current Version: Bug fixes and other changes" of sdk/RELEASE.md?
Sounds good, thanks @connor-mccarthy |
@Mithil467: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm Thank you for this, @Mithil467! The community will benefit greatly from this fix. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: connor-mccarthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…nents. Fixes kubeflow#8385 (kubeflow#9157) * Add module directory to sys.path * Add nested module imports unit test * Add release note to release.md
Description of your changes:
Prepends the
module_directory
to sys.path.module_directory
is WindowsPath object on windows, hence casting to string as sys.path doesn't support pathlib objects.Checklist: