Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): allow user to choose platform for component container build. Fixes #8883 #9212

Merged
merged 1 commit into from
Apr 25, 2023
Merged

fix(sdk): allow user to choose platform for component container build. Fixes #8883 #9212

merged 1 commit into from
Apr 25, 2023

Conversation

browningjp
Copy link
Contributor

@browningjp browningjp commented Apr 23, 2023

Description of your changes:

Add the --platform option to kfp component build to choose container build architecture. Fixes #8883

Checklist:

@google-oss-prow
Copy link

Hi @browningjp. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@browningjp browningjp changed the title fix(sdk): allow user to choose platform for component container build fix(sdk): allow user to choose platform for component container build. Fixes #8883 Apr 23, 2023
@browningjp
Copy link
Contributor Author

Couple of things for discussion/consideration:

  • Technically this is altering the current behaviour by setting the default platform to linux/amd64. Is this an issue?
  • Unsure about how to approach the unit tests - at the moment I have just tweaked an existing test, but this could be split into additional test(s)

@chensun
Copy link
Member

chensun commented Apr 25, 2023

/ok-to-test

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

@browningjp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-execution-tests 91d18ce link false /test kubeflow-pipelines-sdk-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-prow google-oss-prow bot merged commit b59b708 into kubeflow:master Apr 25, 2023
rd-pong pushed a commit to rd-pong/pipelines that referenced this pull request Apr 26, 2023
…Fixes kubeflow#8883 (kubeflow#9212)

Co-authored-by: Jonny Browning <jonathan.browning@datatonic.com>
jlyaoyuli pushed a commit to jlyaoyuli/pipelines that referenced this pull request Apr 27, 2023
…Fixes kubeflow#8883 (kubeflow#9212)

Co-authored-by: Jonny Browning <jonathan.browning@datatonic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdk] Fail running Containerized Python components from kfp v2.0.0.b12 on Vertex
2 participants