Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.23.1 #2155

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Upgrade to Go 1.23.1 #2155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

ARG SPARK_IMAGE=spark:3.5.0

FROM golang:1.22.5 AS builder
FROM golang:1.23.1 AS builder

WORKDIR /workspace

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/kubeflow/spark-operator

go 1.22.5
go 1.23.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I've read, it seems the general perspective is that the go.mod version can follow the latest toolchain for applications, but libraries should use the lowest compatible version so that consumers don't necessarily need to bump their toolchain.

The controller and webhook are applications and aren't consumed externally so these can follow the latest toolchain updates, however for anyone consuming the generated clients/informers/structs under pkg/client this version bump could be annoying.


require (
cloud.google.com/go/storage v1.43.0
Expand Down