Use userinfo.email scope with kube API Client #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlewi
changed the title
See: kubernetes-client/python-base#54 kubernetes-client/python-base#54 * The python client libs need to include userinfo.email when requesting scopes because otherwise RBAC might not work correctly because we won't be able to map the account/user correctly to role/cluster bindings for the email. * ksonnet doesn't have the fixes to the go client lib so for now we just update our docs to work around it by including a cluster role binding for the numeric id. * Update the debug worker to use the image in kubeflow-ci.
jlewi
force-pushed
the
update_debugworker
branch
from
d234370
to
9fdbb6e
Compare
|
/assign @lluunn |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lluunn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and we will get RBAC roles because of missing bindings.