Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow test on Katib release-0.12 branch #965

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Allow test on Katib release-0.12 branch #965

merged 1 commit into from
Aug 25, 2021

Conversation

andreyvelich
Copy link
Member

Which issue is resolved by this Pull Request:
Related: kubeflow/katib#1597.

Description of your changes:
I allow tests on Katib release-0.12 branch

/assign @PatrickXYS
/cc @gaocegege @johnugeorge

Checklist:

If PR related to Optional-Test-Infra,

  • Changes need to be generated to aws/GitOps folder:
    1. cd aws
    2. make optional-generate
    3. make optional-test

@google-cla google-cla bot added the cla: yes label Aug 25, 2021
PatrickXYS
PatrickXYS approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@PatrickXYS PatrickXYS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@andreyvelich feel free to unhold to merge the PR

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member Author

Thank you @PatrickXYS!
/hold cancel

@google-oss-robot google-oss-robot merged commit 0b43bf4 into kubeflow:master Aug 25, 2021
@andreyvelich andreyvelich deleted the allow-test-katib-0.12 branch September 24, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickXYS PatrickXYS PatrickXYS approved these changes

@gaocegege gaocegege Awaiting requested review from gaocegege

@johnugeorge johnugeorge Awaiting requested review from johnugeorge

Assignees

@PatrickXYS PatrickXYS

Labels
approved cla: yes lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreyvelich @google-oss-robot @PatrickXYS