Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap TF with Training Operator #967

Conversation

andreyvelich
Copy link
Member

Recently we renamed tf-operator to training-operator: kubeflow/training-operator#1348.
We should make the appropriate changes in the prow settings.

/assign @kubeflow/wg-training-leads

@PatrickXYS Do you know, does prow cluster automatically carry the new changes ?

Checklist:

If PR related to Optional-Test-Infra,

  • Changes need to be generated to aws/GitOps folder:
    1. cd aws
    2. make optional-generate
    3. make optional-test

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold until we are clear on how the change is going to take effect

/lgtm
/hold

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andreyvelich
Copy link
Member Author

/hold cancel
Let's try to merge it and see if prow will use the new repo.

@Jeffwan
Copy link
Member

Jeffwan commented Oct 8, 2021

Let me reach out to @PatrickXYS to leave a comment

@Jeffwan
Copy link
Member

Jeffwan commented Oct 8, 2021

The cluster does automatically pick up latest changes.

@andreyvelich
Copy link
Member Author

It's great news @Jeffwan!
@PatrickXYS @theofpa @Bobgy @capri-xiyue @zijianjoy Please help with approval this PR.

@theofpa
Copy link
Member

theofpa commented Oct 8, 2021

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, Jeffwan, terrytangyuan, theofpa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit e0b2240 into kubeflow:master Oct 8, 2021
@andreyvelich andreyvelich deleted the change-tf-to-training-operator branch October 8, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants