-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap TF with Training Operator #967
Swap TF with Training Operator #967
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold until we are clear on how the change is going to take effect
/lgtm
/hold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/hold cancel |
Let me reach out to @PatrickXYS to leave a comment |
The cluster does automatically pick up latest changes. |
It's great news @Jeffwan! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, Jeffwan, terrytangyuan, theofpa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Recently we renamed
tf-operator
totraining-operator
: kubeflow/training-operator#1348.We should make the appropriate changes in the prow settings.
/assign @kubeflow/wg-training-leads
@PatrickXYS Do you know, does prow cluster automatically carry the new changes ?
Checklist:
If PR related to Optional-Test-Infra,
aws/GitOps
folder:cd aws
make optional-generate
make optional-test