Replace IsSuspend() with IsSuspended()

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
kubeflow · Jul 13, 2023 · c1af716 · c1af716
1 parent a170326
commit c1af716
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/pkg/controller.v1/common/job.go b/pkg/controller.v1/common/job.go
@@ -167,7 +167,7 @@ func (jc *JobController) ReconcileJobs(
 		}
 		return nil
 	}
-	if commonutil.IsSuspend(jobStatus) {
+	if commonutil.IsSuspended(jobStatus) {
 		msg := fmt.Sprintf("%s %s is resumed.", jobKind, jobName)
 		if err = commonutil.UpdateJobConditions(&jobStatus, apiv1.JobSuspended, corev1.ConditionFalse,
 			commonutil.NewReason(jobKind, commonutil.JobResumedReason), msg); err != nil {

diff --git a/pkg/util/status.go b/pkg/util/status.go
@@ -46,7 +46,7 @@ func IsRunning(status apiv1.JobStatus) bool {
 	return hasCondition(status, apiv1.JobRunning)
 }
 
-func IsSuspend(status apiv1.JobStatus) bool {
+func IsSuspended(status apiv1.JobStatus) bool {
 	return hasCondition(status, apiv1.JobSuspended)
 }
 

diff --git a/pkg/util/status_test.go b/pkg/util/status_test.go
@@ -53,7 +53,7 @@ func TestIsSuspend(t *testing.T) {
 			},
 		},
 	}
-	assert.True(t, IsSuspend(jobStatus))
+	assert.True(t, IsSuspended(jobStatus))
 }
 
 func TestUpdateJobConditions(t *testing.T) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -53,7 +53,7 @@ func TestIsSuspend(t *testing.T) { @@
     			},
     		},
     	}
-    	assert.True(t, IsSuspend(jobStatus))
+    	assert.True(t, IsSuspended(jobStatus))
     }
     func TestUpdateJobConditions(t *testing.T) {
@@ Expand Down @@