Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display coverage % in GitHub actions list #1442

Closed
tenzen-y opened this issue Oct 8, 2021 · 5 comments
Closed

Display coverage % in GitHub actions list #1442

tenzen-y opened this issue Oct 8, 2021 · 5 comments

Comments

@tenzen-y
Copy link
Member

tenzen-y commented Oct 8, 2021

/kind feature

Display coverage report in GitHub actions lists same as coverallsapp/coveralls-node-demo#18.

Discussion: #1440 (comment)

cc @andreyvelich @Jeffwan

@andreyvelich
Copy link
Member

andreyvelich commented Oct 9, 2021

As I can see the Coveralls reports results are properly added in the PR after each build: #1434 (comment)
Which should work for us.

I think the reason why we don't see the similar message in Katib is because settings are disabled.

@james-jwu @Bobgy @zijianjoy Since you have Katib repository admin permission, please can you check if settings are correct by using this link: https://coveralls.io/github/kubeflow/katib/settings

Screenshot 2021-10-09 at 01 07 51

@tenzen-y
Copy link
Member Author

tenzen-y commented Oct 9, 2021

@andreyvelich
Thanks for looking into it.

@andreyvelich
Copy link
Member

Great news, I guess the coveralls messaging is working for Katib: kubeflow/katib#1632 (comment).
Thank you @zijianjoy for activating this setting!

@tenzen-y Feel free to close the issue.

@tenzen-y
Copy link
Member Author

Thanks for telling me! @andreyvelich
/close

@google-oss-robot
Copy link

@tenzen-y: Closing this issue.

In response to this:

Thanks for telling me! @andreyvelich
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants