Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mpijob-controller #1728

Open
tenzen-y opened this issue Jan 17, 2023 · 7 comments
Open

Refactor mpijob-controller #1728

tenzen-y opened this issue Jan 17, 2023 · 7 comments

Comments

@tenzen-y
Copy link
Member

Currently, the mpijob-controller has logic similar to kubeflow/common by oneself since the mpijob-controller does not depend on kubeflow/common.

So when we want to fix or add controller logic, we must apply the same patches to kubeflow/common and mpijob-controller.

Since that is a high maintenance cost, it might be better to refactor the mpijob-controller using kubeflow/common.

@tenzen-y
Copy link
Member Author

/kind feature

@terrytangyuan
Copy link
Member

Great idea.

@johnugeorge
Copy link
Member

Related: #1714

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tenzen-y
Copy link
Member Author

/remove-lifecycle stale

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tenzen-y
Copy link
Member Author

/lifecycle frozen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants