Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully consolidate tfjob-operator to training-operator #1850

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jul 5, 2023

What this PR does / why we need it:
I modified the following items to consolidate tfjob-operator to training-operator fully:

  1. Add the GetFrameworkName function to the Controller interface.
  2. Remove the ReconcilePods from the tfjob-controller to stop overriding the method of the JobController.
  3. Adopt ReconcilePods of the JobController to TFJob.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1727

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@coveralls
Copy link

coveralls commented Jul 5, 2023

Pull Request Test Coverage Report for Build 5467682454

  • 26 of 59 (44.07%) changed or added relevant lines in 7 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.6%) to 33.122%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/mpi/mpijob_controller.go 6 8 75.0%
pkg/controller.v1/pytorch/pytorchjob_controller.go 6 9 66.67%
pkg/controller.v1/paddlepaddle/paddlepaddle_controller.go 5 9 55.56%
pkg/controller.v1/common/pod.go 0 8 0.0%
pkg/controller.v1/mxnet/mxjob_controller.go 0 8 0.0%
pkg/controller.v1/xgboost/xgboostjob_controller.go 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/common/pod.go 1 2.81%
pkg/controller.v1/paddlepaddle/paddlepaddle_controller.go 9 56.38%
Totals Coverage Status
Change from base Build 5456654753: -0.6%
Covered Lines: 3185
Relevant Lines: 9616

💛 - Coveralls

@tenzen-y
Copy link
Member Author

tenzen-y commented Jul 5, 2023

/assign @johnugeorge

@johnugeorge
Copy link
Member

Thanks for the cleanup. MPIJob is the only one now which has overriden ReconcilePods. This has a different implementation anyways.

@tenzen-y
Copy link
Member Author

tenzen-y commented Jul 5, 2023

Thanks for the cleanup. MPIJob is the only one now which has overriden ReconcilePods. This has a different implementation anyways.

Yes, we should refactor the whole of MPIJob: #1728

@johnugeorge
Copy link
Member

Thanks @tenzen-y
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jul 5, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit fcdf9a3 into kubeflow:master Jul 5, 2023
24 checks passed
@tenzen-y tenzen-y deleted the fully-consolidate-tfjob branch July 5, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully consolidate tf-operator to training-operator
3 participants