Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default value for CleanPodPolicy is inconsistent. #1753

Closed
Syulin7 opened this issue Feb 8, 2023 · 3 comments · Fixed by kubeflow/common#210 or #1754
Closed

The default value for CleanPodPolicy is inconsistent. #1753

Syulin7 opened this issue Feb 8, 2023 · 3 comments · Fixed by kubeflow/common#210 or #1754

Comments

@Syulin7
Copy link
Contributor

Syulin7 commented Feb 8, 2023

In the comments of common, the default value is Running:

type RunPolicy struct {
	// CleanPodPolicy defines the policy to kill pods after the job completes.
	// Default to Running.
	CleanPodPolicy *CleanPodPolicy `json:"cleanPodPolicy,omitempty"`

In actuality:

  • mpiJob's default cleanpod policy is None.
  • mxJob's default cleanpod policy is All.
  • paddleJob's default cleanpod policy is None.
  • pytorchJob's default cleanpod policy is None.
  • tfJob's default cleanpod policy is Running.
  • XGBoostJob's default cleanpod policy is All.

Should we set all jobs default to Running, or remove the comments(// Default to Running.) in common.

@johnugeorge
Copy link
Member

Thanks for reporting this.

Yes. This has to be consistent. I think, we can keep defaults to None IMO.

/cc @terrytangyuan @gaocegege @tenzen-y

@tenzen-y
Copy link
Member

tenzen-y commented Feb 8, 2023

I agree. We should set None as default. Setting Running as default looks weird to me.

@terrytangyuan
Copy link
Member

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants