Change the default value of CleanPodPolicy to None in comments.

[Syulin7]

Set None as default.

Fixes: kubeflow/training-operator#1753

[johnugeorge]

/lgtm

[Syulin7]

build/test was failed:

Run golangci-lint run --config=linter_config.yaml ./...
level=warning msg="[runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused."
level=warning msg="[runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused."
Error: pkg/controller.v1/common/job_test.go:194:2: SA4017: AddDate doesn't have side effects and its return value is ignored (staticcheck)
	oneDayAgo.AddDate(0, 0, -1)
	^
Error: Process completed with exit code 1.

@johnugeorge @tenzen-y Do you know the reason why it happened, or can you help make it retry.

[tenzen-y]

I guess the behavior of staticcheck changed since we always install the latest golangci-lint like the following:

common/.github/workflows/build.yml

Line 42 in 9ec55d1

curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin

So we need to fix the lint error. Can you fix the error?

[Syulin7]

OK, I'll give it a try.

[Syulin7]

@tenzen-y I fixed the error, can you help make it retry.

[tenzen-y]

@tenzen-y I fixed the error, can you help make it retry.

Thanks for fixing the error. However, I don't have permission to approve the CI.

@kubeflow/wg-training-leads Can you approve CI?

[Syulin7]

@johnugeorge @terrytangyuan PTAL, thanks.

[johnugeorge]

Thanks @Syulin7

/lgtm
/approve

[Syulin7]

@terrytangyuan @gaocegege @Jeffwan PTAL, thanks.

[terrytangyuan]

No code changes?

[Syulin7]

the code changes in training operator, PR: kubeflow/training-operator#1754. and there are only comments in the common library. The generation of the CRD in the training operator will use it.

[terrytangyuan]

/lgtm

[johnugeorge]

@terrytangyuan Can you merge it as well?

[terrytangyuan]

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment