Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Change the default value of CleanPodPolicy to None in comments. #210

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Change the default value of CleanPodPolicy to None in comments. #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/apis/common/v1/openapi_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/apis/common/v1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ const (
// active.
type RunPolicy struct {
// CleanPodPolicy defines the policy to kill pods after the job completes.
// Default to Running.
// Default to None.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No code changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code changes in training operator, PR: kubeflow/training-operator#1754. and there are only comments in the common library. The generation of the CRD in the training operator will use it.

CleanPodPolicy *CleanPodPolicy `json:"cleanPodPolicy,omitempty"`

// TTLSecondsAfterFinished is the TTL to clean up jobs.
Expand Down
2 changes: 1 addition & 1 deletion pkg/controller.v1/common/job_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ func TestCleanupJobIfTTL(T *testing.T) {
}
oneDayAgo := time.Now()
// one day ago
oneDayAgo.AddDate(0, 0, -1)
_ = oneDayAgo.AddDate(0, 0, -1)
jobStatus := apiv1.JobStatus{
CompletionTime: &metav1.Time{
Time: oneDayAgo,
Expand Down