-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider the way to inform users that the specified gang scheduler isn't supported #1811
Comments
/remove-kind discussion |
cc: @Syulin7 |
Do we need to check if the podgroup CRD exists? Users should ensure that their scheduler can support Volcano podgroup or scheduler-plugins podgroup. |
It sounds good to me. If users set @johnugeorge wdyt? |
The key question is, Are we planning to support only volcano and scheduler plugins in the future? If we are,(due to overhead in management), it sounds good to me. Else, it might be better to make CRD check to be dynamic(like in https://github.com/kubeflow/katib/blob/master/cmd/katib-controller/v1beta1/main.go#L62) |
Makes sense. |
@Syulin7 Any thoughts? |
Agree, users decide whether or not to check the podgroup CRD themselves? |
Probably, we can have podgroups for the volcano and the scheudler-plugins as a default. |
@Syulin7 Do you have enough time to work on this? |
/assign |
@Syulin7 Do you have any progress? |
@Syulin7 Do you have any update? |
Since #1747, we have treated the
scheduler-plugins
as a default gang-scheduler, and we use thescheduler-plugins
if users set anything other thanvolcano
to https://github.com/kubeflow/training-operator/blob/6d6d83dfe7d8c3f4f3938c00c04d8b7410caa205/cmd/training-operator.v1/main.go#LL76C1-L77C105.So, if the specified gang scheduler isn't supported in the training operator, informing that would be better.
/cc @johnugeorge
The text was updated successfully, but these errors were encountered: