Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check podGroup CRD for the volcano and the scheudler-plugins as default. #1929

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

Syulin7
Copy link
Contributor

@Syulin7 Syulin7 commented Oct 9, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1811

Checklist:

  • Docs included if any changes are user facing

@Syulin7
Copy link
Contributor Author

Syulin7 commented Oct 9, 2023

@johnugeorge @tenzen-y Considering that currently only volcano and scheduler-plugins are supported, when a user enables the gang scheduler, it will automatically check the corresponding CRD and remind the user to install it.

cmd/training-operator.v1/main.go Outdated Show resolved Hide resolved
cmd/training-operator.v1/main.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Oct 10, 2023

Pull Request Test Coverage Report for Build 6468588469

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 42.802%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob.go 1 91.06%
Totals Coverage Status
Change from base Build 6447526111: -0.01%
Covered Lines: 3746
Relevant Lines: 8752

💛 - Coveralls

cmd/training-operator.v1/main.go Outdated Show resolved Hide resolved
cmd/training-operator.v1/main.go Outdated Show resolved Hide resolved
cmd/training-operator.v1/main.go Outdated Show resolved Hide resolved
@Syulin7 Syulin7 force-pushed the check-crd branch 2 times, most recently from 3134f5e to 2735a86 Compare October 10, 2023 09:55
…ault.

Signed-off-by: Syulin7 <735122171@qq.com>
@Syulin7
Copy link
Contributor Author

Syulin7 commented Oct 10, 2023

@johnugeorge @tenzen-y Thanks for the review! please take a look again.

@johnugeorge
Copy link
Member

/lgtm

/assign @tenzen-y

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that building pipeline for the example image crashed due to "no space left on device" error.

I will submit the PR to fix the issue. Anyway, this PR looks good. @Syulin7 Thank you!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Syulin7, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f5f4717 into kubeflow:master Oct 10, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider the way to inform users that the specified gang scheduler isn't supported
4 participants