-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check podGroup CRD for the volcano and the scheudler-plugins as default. #1929
Conversation
@johnugeorge @tenzen-y Considering that currently only volcano and scheduler-plugins are supported, when a user enables the gang scheduler, it will automatically check the corresponding CRD and remind the user to install it. |
Pull Request Test Coverage Report for Build 6468588469
💛 - Coveralls |
3134f5e
to
2735a86
Compare
…ault. Signed-off-by: Syulin7 <735122171@qq.com>
@johnugeorge @tenzen-y Thanks for the review! please take a look again. |
/lgtm /assign @tenzen-y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that building pipeline for the example image crashed due to "no space left on device" error.
I will submit the PR to fix the issue. Anyway, this PR looks good. @Syulin7 Thank you!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Syulin7, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #1811
Checklist: