Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: runPolicy validation error in the examples #1401

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Sep 6, 2021

Since we move "cleanPodPolicy" to runPolicy umbrella and enable CRD validation. some examples can not be submitted.

This PR helps update the examples still using the old pattern.

kubectl apply -f tf_job_mnist.yaml
error: error validating "tf_job_mnist.yaml": error validating data: ValidationError(TFJob.spec): unknown field "cleanPodPolicy" in org.kubeflow.v1.TFJob.spec; if you choose to ignore these errors, turn validation off with --validate=false

@Jeffwan Jeffwan changed the title fix: runPolicy issue in the examples fix: runPolicy validation error in the examples Sep 6, 2021
@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 1aa44a6 into kubeflow:master Sep 6, 2021
@Jeffwan Jeffwan deleted the fix_small_issue branch September 7, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants