Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick of #1409: Bump controller-tools to 0.6.0 and enable GenerateEmbeddedObjectMeta #1410

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Sep 20, 2021

No description provided.

@Jeffwan Jeffwan changed the title Automated cherry pick of #1409: Bump controller-tools to 0.6.0 and enable Cherry pick of #1409 on v1.3-branch. #1409: Bump controller-tools to 0.6.0 and enable For details on the cherry pick process, see the [cherry pick requests](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) page. Cherry pick of #1409: Bump controller-tools to 0.6.0 and enable GenerateEmbeddedObjectMeta Sep 20, 2021
@Jeffwan
Copy link
Member Author

Jeffwan commented Sep 20, 2021

/cc @andreyvelich @zijianjoy

@Jeffwan
Copy link
Member Author

Jeffwan commented Sep 20, 2021

/approve

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit d4423c8 into kubeflow:v1.3-branch Sep 20, 2021
@Jeffwan Jeffwan deleted the automated-cherry-pick-of-#1409-upstream-v1.3-branch branch September 20, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants