Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent naming for better readability #1449

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

pramodrj07
Copy link
Contributor

this change is as per the discussion in the link below
#1418 (comment)

@aws-kf-ci-bot
Copy link
Contributor

Hi @pramodrj07. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pramodrj07
To complete the pull request process, please assign chanyilin after the PR has been reviewed.
You can assign the PR to them by writing /assign @chanyilin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Oct 14, 2021

Pull Request Test Coverage Report for Build 1411679035

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 8.152%

Totals Coverage Status
Change from base Build 1397944908: 0.0%
Covered Lines: 311
Relevant Lines: 3815

💛 - Coveralls

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update links in README as well

@Jeffwan
Copy link
Member

Jeffwan commented Oct 23, 2021

@pramodrj07 Do you get a chance to address to address Terry's comment?

@gaocegege
Copy link
Member

ping @pramodrj07 Hi do you still work on it?

@pramodrj07
Copy link
Contributor Author

pramodrj07 commented Nov 1, 2021

ping @pramodrj07 Hi do you still work on it?

Hi @gaocegege. Yes, I am working on it. I will push the update in a few hours.

@gaocegege
Copy link
Member

Thanks!

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @terrytangyuan

Thanks for your contribution! 🎉 👍

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pramodrj07, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 72e4387 into kubeflow:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants