Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add .gitattributes to ignore Jsonnet test code for linguist #1463

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

terrytangyuan
Copy link
Member

Jsonnet is recognized as the main language of this repo but it's only for testing and shouldn't be included as part of the classification.

Reference: https://github.com/github/linguist/blob/master/docs/overrides.md#generated-code

Signed-off-by: terrytangyuan terrytangyuan@gmail.com

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gaocegege,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1451591201

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 8.15%

Totals Coverage Status
Change from base Build 1441186837: 0.0%
Covered Lines: 311
Relevant Lines: 3816

💛 - Coveralls

@google-oss-prow google-oss-prow bot merged commit 654540b into master Nov 12, 2021
@terrytangyuan terrytangyuan deleted the linguist-fix branch November 12, 2021 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants