Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR template with doc checklist #1470

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

andreyvelich
Copy link
Member

As we discussed on the WG meeting, it is better to add the doc checklist to our PR template.

Once our contributors submit the new PR with feature request, they have to update the Kubeflow docs.

/assign @kubeflow/wg-training-leads

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1471956311

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 8.15%

Totals Coverage Status
Change from base Build 1469743892: 0.0%
Covered Lines: 311
Relevant Lines: 3816

💛 - Coveralls

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c3a867e into kubeflow:master Nov 17, 2021
@andreyvelich andreyvelich deleted the add-pr-template branch November 17, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants