Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Because the tf-controller overrides the
ReconcilePods
function, the updated labels withtraining.kubeflow.org
prefix are not added to the metainfo of tf pod generated. However, for the selector in tf service, because tf-controller does not overrides theReconcilePods
, labels withtraining.kubeflow.org
prefix are included.Checklist:
"training.kubeflow.org/replica-type"
and"training.kubeflow.org/replica-index"
to tf-controller when generating labels