add expectation-related functions for other resources used in mpi-controller

[zw0610]

fix issues related to controller logic from comment #1457 (review)

[coveralls]

Pull Request Test Coverage Report for Build 1581041831

• 29 of 36 (80.56%) changed or added relevant lines in 1 file are covered.
• 248 unchanged lines in 6 files lost coverage.
• Overall coverage increased (+3.7%) to 27.75%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/controller.v1/mpi/mpijob_controller.go	29	36	80.56%

Files with Coverage Reduction	New Missed Lines	%
pkg/apis/pytorch/validation/validation.go	2	91.67%
pkg/apis/tensorflow/v1/openapi_generated.go	13	0%
pkg/apis/xgboost/v1/openapi_generated.go	13	0%
pkg/apis/mxnet/v1/openapi_generated.go	14	0%
pkg/controller.v1/pytorch/pytorchjob_controller.go	49	61.65%
pkg/controller.v1/mpi/mpijob_controller.go	157	75.35%

Totals
Change from base Build 1493027296:	3.7%
Covered Lines:	1703
Relevant Lines:	6137

---

💛 - Coveralls

[zw0610]

Hi @Jeffwan and @terrytangyuan , this pull request mainly focus on the expectation things with mpi-operator.

I understand the importance of expectation for controllers when implemented without controller-runtime. With the training-operator fully built on kubebuilder, do we still need expectation related logic?

This question amplifies with mpi-controller.v1 because unlike other controllers, mpi-controller.v1 utilizes and watches Kubernetes resources besides Pod and Service, making the existing expectation functions insufficient to deal with. While I made some generic expectation functions in this pull request, I'm also thinking if they are redundant.

WDYT?

[terrytangyuan]

LGTM in general. Just a couple of minor grammatical suggestions. Could you also update the PR title and description to reflect the changes?

[terrytangyuan]

Are we not checking the import order in the CI? If not, we should probably add.

[zw0610]

I think not. The imports are formatted by goimports, which seems not good enough in this case. Just opened a new issue to track this.

[terrytangyuan]

Thanks!

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan, zw0610

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [terrytangyuan,zw0610]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment