fix comments for mpi-controller

[hackerboy01]

fix comments for mpi-controller

[aws-kf-ci-bot]

Hi @hackerboy01. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[coveralls]

Pull Request Test Coverage Report for Build 1506096008

• 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.4%) to 24.48%

---

Totals
Change from base Build 1493027296:	0.4%
Covered Lines:	1224
Relevant Lines:	5000

---

💛 - Coveralls

[zw0610]

Suggested change

	// DefaultContainerName is the name of the mpiJob container.
	// DefaultContainerName is the name of the MPIJob container.

[zw0610]

/ok-to-test

[hackerboy01]

/retest

[zw0610]

Hi, @terrytangyuan could you review this fix pr?

[hackerboy01]

Hi, @terrytangyuan v1 MPI operator has been migrated to this repo #1457, such as cluster-role.yaml I just copy and paste from V1 mpi-operator, some comments should be addressed, please take a look for the PR.

[terrytangyuan]

Thanks!

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hackerboy01, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alculquicondor]

How are we going to asses if the migrated v1 controller is prod ready?

[zw0610]

How are we going to asses if the migrated v1 controller is prod ready?

I think it will be great if someone can offer a universal standard to access if it is production ready for all tf, pytorch, mxnet, xbgoost and mpi (v1 & v2) controllers rather than a specific one set for mpi v1 controller. Do you think you can contribute?

[alculquicondor]

I can help review the standard. But I think as a general rule of thumb we need E2E tests and perhaps some percentage of coverage in unit level.

[alculquicondor]

Was the above satisfied?