Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix torch env typo #1573

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Conversation

kuizhiqing
Copy link
Member

What this PR does / why we need it:
There is a wrong env set for pytorch.

PET_N_PROC_PER_NODE should be PET_NPROC_PER_NODE according to
https://github.com/pytorch/pytorch/blob/master/torch/distributed/argparse_util.py#L12-L57

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • [*] Docs included if any changes are user facing

@google-cla
Copy link

google-cla bot commented Apr 11, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@aws-kf-ci-bot
Copy link
Contributor

Hi @kuizhiqing. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for your contribution! 🎉 👍

@gaocegege
Copy link
Member

/ok-to-test

@gaocegege
Copy link
Member

Please sign the CLA

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2147091797

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 37.172%

Totals Coverage Status
Change from base Build 2063930985: 0.0%
Covered Lines: 2308
Relevant Lines: 6209

💛 - Coveralls

@kuizhiqing
Copy link
Member Author

/retest

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, kuizhiqing, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gaocegege,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

/retest

@google-oss-prow google-oss-prow bot merged commit b4cea34 into kubeflow:master Apr 12, 2022
@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants