Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix wrong parameter for resolveControllerRef #1583

Merged
merged 2 commits into from
Jul 21, 2022
Merged

fix: fix wrong parameter for resolveControllerRef #1583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c343fdd
fix: fix wrong parameter for resolveControllerRef
fighterhit May 4, 2022
5fa872f
Merge branch 'kubeflow:master' into fix-wrong-parameter
fighterhit Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/common/util/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func OnDependentUpdateFunc(jc *common.JobController) func(updateEvent event.Upda

if controllerRefChanged && oldControllerRef != nil {
// The ControllerRef was changed. Sync the old controller, if any.
if job := resolveControllerRef(jc, oldObj.GetName(), oldControllerRef); job != nil {
if job := resolveControllerRef(jc, oldObj.GetNamespace(), oldControllerRef); job != nil {
logger.Infof("pod/service controller ref updated: %v, %v", newObj, oldObj)
return true
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/common/util/reconciler_generic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func OnDependentUpdateFuncGeneric(jc *common.JobController) func(updateEvent eve

if controllerRefChanged && oldControllerRef != nil {
// The ControllerRef was changed. Sync the old controller, if any.
if job := resolveControllerRef(jc, oldObj.GetName(), oldControllerRef); job != nil {
if job := resolveControllerRef(jc, oldObj.GetNamespace(), oldControllerRef); job != nil {
logger.Infof("%s controller ref updated: %v, %v", kind, newObj, oldObj)
return true
}
Expand Down