Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for k8s v1.25 in CI #1684

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Support for k8s v1.25 in CI #1684

merged 3 commits into from
Nov 2, 2022

Conversation

johnugeorge
Copy link
Member

Adds k8s v1.25 in CI. Removed v1.22 from CI

Fixes: #1682

@coveralls
Copy link

coveralls commented Nov 2, 2022

Pull Request Test Coverage Report for Build 3379369607

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 39.561%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 4 77.2%
Totals Coverage Status
Change from base Build 3313606251: 0.0%
Covered Lines: 2342
Relevant Lines: 5920

💛 - Coveralls

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnugeorge Thanks for updating k8s version!
Can we also update the k8s go libraries version?

training-operator/go.mod

Lines 13 to 16 in 74655a1

k8s.io/api v0.24.1
k8s.io/apimachinery v0.24.1
k8s.io/client-go v0.24.1
k8s.io/code-generator v0.24.1

@google-oss-prow google-oss-prow bot added size/XXL and removed size/XS labels Nov 2, 2022
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnugeorge,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1c6b7cc into kubeflow:master Nov 2, 2022
@tenzen-y tenzen-y mentioned this pull request Nov 3, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Kubernetes v1.25
4 participants