Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status lost #1697

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Fix status lost #1697

merged 1 commit into from
Dec 5, 2022

Conversation

ggaaooppeenngg
Copy link
Contributor

common package uses jobStatus to update job. This
fix makes up the loss of start and completion time of status.

Signed-off-by: Peng Gao peng.gao.dut@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

common package uses jobStatus to update job. This
fix makes up the loss of start and completion time of status.

Signed-off-by: Peng Gao <peng.gao.dut@gmail.com>
@coveralls
Copy link

coveralls commented Dec 5, 2022

Pull Request Test Coverage Report for Build 3619017740

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 39.632%

Totals Coverage Status
Change from base Build 3586267075: 0.2%
Covered Lines: 2693
Relevant Lines: 6795

💛 - Coveralls

@johnugeorge
Copy link
Member

Thanks @ggaaooppeenngg

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggaaooppeenngg, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 25ba7c2 into kubeflow:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants