Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update Kubernetes requirement and version matrix #1721

Merged
merged 2 commits into from
Jan 11, 2023
Merged

docs: Update Kubernetes requirement and version matrix #1721

merged 2 commits into from
Jan 11, 2023

Conversation

terrytangyuan
Copy link
Member

This looks pretty outdated.

@coveralls
Copy link

coveralls commented Jan 11, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3893821453

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+4.6%) to 39.364%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 5 77.37%
Totals Coverage Status
Change from base Build 3811462732: 4.6%
Covered Lines: 2672
Relevant Lines: 6788
💛 - Coveralls

tenzen-y
tenzen-y reviewed Jan 11, 2023
View reviewed changes
README.md Outdated
Comment on lines 98 to 99
| `v1.4.x` | `v1` | 1.23+ |
| `latest` (master HEAD) | `v1` | 1.23+ |
Copy link
Member

@tenzen-y tenzen-y Jan 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add v1.5.x?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

tenzen-y
tenzen-y reviewed Jan 11, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrytangyuan Thanks!
/lgtm
/hold for reviewers

@google-oss-prow google-oss-prow bot added the lgtm label Jan 11, 2023
@johnugeorge
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnugeorge,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnugeorge
Copy link
Member

/hold cancel

@google-oss-prow google-oss-prow bot merged commit ddf372c into master Jan 11, 2023
@terrytangyuan terrytangyuan deleted the terrytangyuan-patch-1 branch January 11, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@johnugeorge johnugeorge johnugeorge approved these changes

@jinchihe jinchihe Awaiting requested review from jinchihe

@kuizhiqing kuizhiqing Awaiting requested review from kuizhiqing

Assignees

@tenzen-y tenzen-y

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@terrytangyuan @coveralls @johnugeorge @tenzen-y