Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI to build example images #1731

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jan 20, 2023

Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com

What this PR does / why we need it:
I added the GHA config to build example images.
I verified operations using the following images:

  • ytenzen/tf-dist-mnist-test:latest
  • ytenzen/tf-distributed-worker:latest
  • ytenzen/tf-multi-worker-strategy:latest
  • ytenzen/tf-mnist-with-summaries:latest
  • ytenzen/tf-smoke:latest
  • ytenzen/pytorch-dist-sendrecv-test:latest
  • ytenzen/pytorch-elastic-example-imagenet:latest
  • ytenzen/pytorch-elastic-example-echo:latest

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Comment on lines +41 to +55
# TODO (tenzen-y): Fix the below broken Dockerfiles
# - component-name: lightgbm-dist-py-test
# dockerfile: examples/xgboost/lightgbm-dist/Dockerfile
# - component-name: xgboost-dist-rabit-test
# dockerfile: examples/xgboost/smoke-dist/Dockerfile
# - component-name: xgboost-dist-iris
# dockerfile: examples/xgboost/xgboost-dist
# - component-name: mxnet-gpu
# dockerfile: examples/mxnet/train/Dockerfile
# - component-name: mxnet-auto-tuning
# dockerfile: examples/mxnet/tune/Dockerfile
# - component-name: pytorch-dist-mnist-mpi
# dockerfile: examples/pytorch/mnist/Dockerfile-mpi
# - component-name: pytorch-dist-mnist
# dockerfile: examples/pytorch/mnist/Dockerfile
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These images could not build or failed to run.
We need to fix these images in other PRs.

@coveralls
Copy link

coveralls commented Jan 20, 2023

Pull Request Test Coverage Report for Build 3966902837

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 39.29%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 77.18%
Totals Coverage Status
Change from base Build 3945489270: 0.07%
Covered Lines: 2667
Relevant Lines: 6788

💛 - Coveralls

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e6b4300 into kubeflow:master Jan 20, 2023
@tenzen-y tenzen-y deleted the add-image-build-ci branch January 20, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants