Fix XGBoost conditions bug #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Pull Request Test Coverage Report for Build 3980353017
💛 - Coveralls |
|
@terrytangyuan @johnugeorge This bug makes confused users. So I would like to add this patch to the next training-operator release. |
|
Thanks @tenzen-y |
1 task
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Can you restart failed CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com
What this PR does / why we need it:
Currently, the xgboostjob-controller adds a
Runningcondition to thestatus.conditionsfield of XGBoostJob when some containers have not been scheduled to Nodes, yet.Although, other controllers (e.g., mxjob-controller and pytorchjob-controller) do not add
Runningcondition to thestatus.conditionof CustomJob in that situation.For example, when we deploy XGBoostJob with coscheduling to insufficient resources K8s Cluster, the xgboostjob-controller adds a
Runningcondition to XGBoostJob, regardless of Pod's status.P.S. I found this issue in #1736
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #
Checklist: