Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yuki to reviewer group #1739

Merged
merged 10 commits into from
Jan 23, 2023
Merged

Add Yuki to reviewer group #1739

merged 10 commits into from
Jan 23, 2023

Conversation

johnugeorge
Copy link
Member

Yuki has actively contributed in training operator for more than a year(Reviews, PRs, Docs). Thanks for all your efforts to make this operator better. I propose him to be in the reviewer group for the training operator.

https://github.com/kubeflow/training-operator/commits?author=tenzen-y

/assign @kubeflow/wg-training-leads

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Jan 23, 2023

Pull Request Test Coverage Report for Build 3984711217

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 39.168%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/paddlepaddle/paddlepaddle_controller.go 3 53.63%
pkg/controller.v1/pytorch/pytorchjob_controller.go 9 58.16%
Totals Coverage Status
Change from base Build 3980850357: 0.1%
Covered Lines: 2692
Relevant Lines: 6873

💛 - Coveralls

@johnugeorge
Copy link
Member Author

/assign @terrytangyuan @gaocegege

@gaocegege
Copy link
Member

/lgtm

@tenzen-y Thanks for your contribution!

@google-oss-prow google-oss-prow bot added the lgtm label Jan 23, 2023
@google-oss-prow google-oss-prow bot merged commit e900cce into kubeflow:master Jan 23, 2023
@tenzen-y
Copy link
Member

Thanks to all WG Training Leads!

@terrytangyuan
Copy link
Member

Congrats! Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants