Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the success condition of the job in PyTorchJob's Elastic mode. #1752

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

Syulin7
Copy link
Contributor

@Syulin7 Syulin7 commented Feb 7, 2023

Signed-off-by: Syulin7 735122171@qq.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1751

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Syulin7 <735122171@qq.com>
@Syulin7 Syulin7 changed the title Bug fix: pytorchjob success condition. Bug fix: pytorchjob elastic mode success condition. Feb 7, 2023
@Syulin7
Copy link
Contributor Author

Syulin7 commented Feb 7, 2023

@johnugeorge PTAL, Thanks.

@Syulin7 Syulin7 changed the title Bug fix: pytorchjob elastic mode success condition. Fix the success condition of the job in PyTorchJob's Elastic mode. Feb 7, 2023
@coveralls
Copy link

coveralls commented Feb 7, 2023

Pull Request Test Coverage Report for Build 4115400145

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 39.33%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 5 76.97%
pkg/controller.v1/pytorch/pytorchjob_controller.go 9 58.19%
Totals Coverage Status
Change from base Build 4066710325: 0.03%
Covered Lines: 2722
Relevant Lines: 6921

💛 - Coveralls

@johnugeorge
Copy link
Member

Thanks @Syulin7 for this fix.

Welcome to community and thanks for the contributions.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, Syulin7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c85040a into kubeflow:master Feb 8, 2023
google-oss-prow bot pushed a commit that referenced this pull request Feb 13, 2023
* Add validation for verifying that the CustomJob (e.g., TFJob) name meets DNS1035 (#1748)

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Fix the success condition of the job in PyTorchJob's Elastic mode. (#1752)

Signed-off-by: Syulin7 <735122171@qq.com>

* Set the default value of CleanPodPolicy to None (#1754)

Signed-off-by: Syulin7 <735122171@qq.com>

* Update mpijob_controller.go (#1755)

fix typo TFJob, should be MPIJob

---------

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Syulin7 <735122171@qq.com>
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Co-authored-by: yu lin <37265556+Syulin7@users.noreply.github.com>
Co-authored-by: Yasser Shalabi <yassershalabi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HPA support for PyTorch Elastic
3 participants